Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
L
l10n_mx_facturae
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • l10n_mx
  • l10n_mx_facturae
  • Merge Requests
  • !79

Merged
Opened 6 years ago by Sotero Toribio Campistrano@sotero.toribioContributor

fix(account.voucher): Pagos a una factura en el mismo día

  • Overview 3
  • Commits 2
  • Changes 7
All threads resolved
  • Loading...

Se cambia la condición de los pagos de la factura, antes se tomaba la fecha de las lineas de account.move.line y lo diferenciaba con la fecha de voucher que se estaba firmando en ese momento. Ahora se filtra la fecha de creación de los pagos con el ultimo pago de esa factura para que haga el proceso correcto y calcule el ImpSaldoInsoluto correctamente.

Closed #31 (closed)

Request to merge sotero.toribio:voucher into master
  • Download as
  • Email patches

  • Plain diff

Checking pipeline status.

Approval is optional

Merged by Agustín Cruz 6 years ago (Feb 24, 2019 3:26am GMT+0000) 6 years ago

The changes were merged into master with 3b912949

Closed #31 (closed)


  • Sotero Toribio Campistrano @sotero.toribio added Bug S labels 6 years ago

    added Bug S labels

  • Sotero Toribio Campistrano
    Sotero Toribio Campistrano @sotero.toribio · 6 years ago
    Contributor

    @OpenPymeMx

    • Agustín Cruz
      Agustín Cruz @agb80 · 6 years ago
      Owner
      Resolved by Agustín Cruz 6 years ago

      Correcciones a los siguientes mensajes del lint:

      ************* Module l10n_mx_facturae
      l10n_mx_facturae/views/account_invoice.xml:40: [W7937(xml-attribute-translatable), ]  The xml attribute is missing the translation="off" tag xml_id
      l10n_mx_facturae/views/account_invoice.xml:41: [W7937(xml-attribute-translatable), ]  The xml attribute is missing the translation="off" tag xml_id
      l10n_mx_facturae/views/account_invoice.xml:42: [W7937(xml-attribute-translatable), ]  The xml attribute is missing the translation="off" tag xml_id
      l10n_mx_facturae/views/account_voucher.xml:41: [W7937(xml-attribute-translatable), ]  The xml attribute is missing the translation="off" tag xml_id
      l10n_mx_facturae/views/account_voucher.xml:42: [W7937(xml-attribute-translatable), ]  The xml attribute is missing the translation="off" tag xml_id
      ************* Module l10n_mx_facturae.models.account_invoice
      l10n_mx_facturae/models/account_invoice.py:422: [R1710(inconsistent-return-statements), AccountInvoiceLine.export_invoice_line_for_xml.process_tax] Either all return statements in a function should return an expression, or none of them should.
      l10n_mx_facturae/models/account_invoice.py:461: [C1801(len-as-condition), AccountInvoiceLine.export_invoice_line_for_xml] Do not use `len(SEQUENCE)` to determine if a sequence is empty
      ************* Module l10n_mx_facturae.models.account_move
      l10n_mx_facturae/models/account_move.py:26: [W8115(translation-contains-variable), AccountMove.button_validate] Translatable term in ""Can't post the entry %s the related invoice is in waiting state to cancel" % account_move.name" contains variables. Use _("Can't post the entry %s the related invoice is in waiting state to cancel") % account_move.name instead
      ************* Module l10n_mx_facturae.report.account_invoice
      l10n_mx_facturae/report/account_invoice.py:11: [R0201(no-self-use), Parser._qrcode_string] Method could be a function
      ************* Module l10n_mx_facturae.report.account_voucher
      l10n_mx_facturae/report/account_voucher.py:10: [E1003(bad-super-call), Parser.__init__] Bad first argument 'self.__class__' given to super()
      l10n_mx_facturae/report/account_voucher.py:13: [R0201(no-self-use), Parser._datosqr] Method could be a function
    • Agustín Cruz
      Last reply by Agustín Cruz 6 years ago
  • Agustín Cruz @agb80 resolved all discussions 6 years ago

    resolved all discussions

  • Agustín Cruz @agb80 mentioned in issue #32 (closed) 6 years ago

    mentioned in issue #32 (closed)

  • Sotero Toribio Campistrano @sotero.toribio added 1 commit 6 years ago

    added 1 commit

    • db37a1c7 - style(l10n_mx_facturae): Estilo en el codigo

    Compare with previous version

  • Sotero Toribio Campistrano @sotero.toribio added 1 commit 6 years ago

    added 1 commit

    • 23c07278 - style(l10n_mx_facturae): Estilo en el codigo

    Compare with previous version

  • Sotero Toribio Campistrano @sotero.toribio added 1 commit 6 years ago

    added 1 commit

    • 64fc4997 - style(l10n_mx_facturae): Estilo en el codigo

    Compare with previous version

  • Sotero Toribio Campistrano @sotero.toribio added 1 commit 6 years ago

    added 1 commit

    • be3de95b - style(l10n_mx_facturae): Estilo en el codigo

    Compare with previous version

  • Sotero Toribio Campistrano @sotero.toribio added 1 commit 6 years ago

    added 1 commit

    • 3b912949 - style(l10n_mx_facturae): Estilo en el codigo

    Compare with previous version

  • Sotero Toribio Campistrano
    Sotero Toribio Campistrano @sotero.toribio · 6 years ago
    Contributor

    @OpenPymeMx Listo ya quedaron los test, lo hice de esa forma de inhabilitar los msj que arrojo el lint para no modificar la funcionalidad.

  • Agustín Cruz @agb80 merged 6 years ago

    merged

  • Agustín Cruz @agb80 mentioned in issue pyerp/bench#53 (closed) 6 years ago

    mentioned in issue pyerp/bench#53 (closed)

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
Assignee
Sotero Toribio Campistrano's avatar
Sotero Toribio Campistrano
@sotero.toribio
Assign to
0 Reviewers
None
Request review from
None
Milestone
None
Assign milestone
None
Time tracking
No estimate or time spent
2
Labels
Bug S
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
10
10 participants
user avatar
user avatar
user avatar
user avatar
user avatar
user avatar
user avatar
Reference: l10n_mx/l10n_mx_facturae!79
Source branch: voucher

    0 pending comments