Skip to content

GitLab

Merged
Opened by Agustín Cruz@agb80Owner

fix(security): allow users in account_invoice group create ir_attachment_facturae_mx recors

Compare
and
12 files
+ 32
- 34
l10n_mx_ir_attachme‎nt_facturae/security‎
ir.model.‎access.csv‎ +2 -1
l10n_mx_p‎arams_pac‎
mod‎els‎
params‎_pac.py‎ +5 -3
pa‎cs‎
expide_tu_‎factura.py‎ +12 -10
finf‎ok.py‎ +11 -9
setu‎p.cfg‎ +2 -11
l10n_mx_ir_attachment_facturae/security/ir.model.access.csv
+ 2
- 1
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
access_ir_attachment_facturae_mx_manager,ir_attachment_facturae_mx_manager,model_ir_attachment_facturae_mx,account.group_account_user,1,1,1,1
access_ir_attachment_facturae_mx_user,ir_attachment_facturae_mx_user,model_ir_attachment_facturae_mx,account.group_account_invoice,1,0,0,0
access_ir_attachment_facturae_mx_user,ir_attachment_facturae_mx_user,model_ir_attachment_facturae_mx,account.group_account_invoice,1,1,1,0
access_ir_attachment_facturae_mx_config_user,ir_attachment_facturae_mx_user,model_ir_attachment_facturae_mx_config,account.group_account_invoice,1,0,0,0
l10n_mx_params_pac/models/params_pac.py
+ 5
- 3
# -*- coding: utf-8 -*-
import exceptions
import logging
from openerp import api, fields, models
from openerp.exceptions import Warning as UserError
from openerp.tools.translate import _
from . import exceptions
logger = logging.getLogger(__name__)
Show 20 lines Show all unchanged lines Show 20 lines
'in sequence will be used first.',
)
certificate_link = fields.Char(
'Certificate link', size=256,
size=256,
help='PAC public certificate used to validate authenticity for a given'
'XML file.',
)
Show 20 lines Show all unchanged lines Show 20 lines
# nevertheless you try with all PACs in the world
# CFDI would be failed
except (
exceptions.ValidationError, exceptions.PrimarySectorError
exceptions.ValidationError, exceptions.PrimarySectorError
) as error:
raise UserError(
_(repr(error)),
)
# TODO: We need to catch errors like timeout and similar
# because the idea is when a PAC fails try next
# pylint: disable=broad-except
except Exception as error:
# If something went wrong try with next PAC
message_error = '\n'.join(
Show 20 lines Show all unchanged lines
l10n_mx_params_pac/pacs/expide_tu_factura.py
+ 12
- 10
Show all unchanged lines Show 20 lines
import re
import string
import tempfile
import xmltodict
from datetime import datetime
from lxml import etree
from pytz import timezone, utc
from requests import Request, Session
import xmltodict
from SOAPpy import WSDL
from openerp import api, fields, models
from openerp.addons.l10n_mx_ir_attachment_facturae.lib import pyxmldsig
from openerp.exceptions import Warning as UserError
from openerp.tools.translate import _
from openerp.addons.l10n_mx_ir_attachment_facturae.lib import pyxmldsig
from ..models import exceptions as pac_exceptions
Show 20 lines Show all unchanged lines Show 20 lines
_logger.debug(data)
headers = {
'SOAPAction': '%s' % (_ACTIONS[method]),
'Content-Type': 'text/xml'
'Content-Type': 'text/xml',
}
s = Session()
req = Request(
'POST', self.url_webservice_sign, data=data, headers=headers
'POST', self.url_webservice_sign, data=data, headers=headers,
)
prepped = req.prepare()
try:
Show 20 lines Show all unchanged lines Show 20 lines
resultado = res['soapenv:Envelope']['soapenv:Body']['ser:timbrarResponse']['return']
except KeyError:
resultado = res['soap:Envelope']['soap:Body']['ns2:timbrarResponse']['return']
except Exception, e:
except Exception:
raise UserError(
_('Unknow answer.\n%s') % resultado
)
Show 20 lines Show all unchanged lines Show 20 lines
else:
return True
def binary2file(self, cr=False, uid=False, ids=[], binary_data=False,
file_prefix="", file_suffix=""):
def binary2file(
self, cr, uid, ids, binary_data=False, file_prefix='',
file_suffix='',
):
"""
@param binary_data : Field binary with the information of certificate
of the company
Show 20 lines Show all unchanged lines Show 20 lines
key_file=fname_key_pem.encode('ascii', 'ignore'),
password=cert.certificate_password.encode('ascii', 'ignore')
)
_logger.debug('Signed file %s' % signed_xml)
_logger.debug('Signed file %s', signed_xml)
return signed_xml # data_dict
@api.model
Show 20 lines Show all unchanged lines Show 20 lines
cancelacion.append(signature)
# pretty string
_logger.debug('XML file %s' % etree.tostring(cancelacion))
_logger.debug('XML file %s', etree.tostring(cancelacion))
return etree.tostring(cancelacion)
l10n_mx_params_pac/pacs/finfok.py
+ 11
- 9
# -*- coding: utf-8 -*-
import logging
from suds.client import Client
from openerp import api, fields, models
Show 20 lines Show all unchanged lines Show 20 lines
_cancel_errors = {
'300': 'Usuario y contraseña inválidos',
'203': 'No corresponde el RFC del Emisor y de quien solicita '
'la cancelación',
'la cancelación',
'205': 'UUID No existe',
'704': 'Error con la contraseña de la llave Privada',
'708': 'No se pudo conectar al SAT',
'711': 'Error con el certificado al cancelar',
'712': 'El número de noCertificado es diferente al del número de'
'certificado del atributo certificado',
'certificado del atributo certificado',
}
Show 20 lines Show all unchanged lines Show 20 lines
code_error = incidencia.CodigoError
if code_error in pac_exceptions.validation_error_list:
raise pac_exceptions.ValidationError(
code=code_error, message=menssage_error)
code=code_error, message=menssage_error,
)
else:
raise Exception(' '.join([code_error, menssage_error]))
# I think, if there is not any Incidencia it is because
Show 20 lines Show all unchanged lines Show 20 lines
else:
return {'cfdi_xml': contenido.xml.decode('utf-8')}
def cancel_cfdi_finkok(self, UUID):
def cancel_cfdi_finkok(self, uuid):
"""Funcion uses to cancel a CFDI in SAT server
using Finkok webservices
Show 20 lines Show all unchanged lines Show 20 lines
company_rfc = company_id.partner_id.vat_split
cer_file = certificate.certificate_file_pem.encode('base64')
key_file = certificate.certificate_key_file_pem.encode('base64')
cfdis = [UUID]
cfdis = [uuid]
try:
server = Client(server_url)
# I thought it was necessary to create at first
# a Soap request but only passing XML in base64 it works
# The next lines are needed by the python suds library
cfdis_list = server.factory.create("UUIDS")
cfdis_list = server.factory.create('UUIDS')
cfdis_list.uuids.string = cfdis
result = server.service.cancel(
cfdis_list, user, password, company_rfc, cer_file, key_file)
cfdis_list, user, password, company_rfc, cer_file, key_file,
)
# Get results, result is always in a list
# but this list has only one value since we only send one
# folio fiscal
Show 20 lines Show all unchanged lines Show 20 lines
result_status = str(folio.EstatusUUID)
if result_status not in ['200', '201']:
raise pac_exceptions.CancelError(
result_status, _cancel_errors.get(result_status, ''))
result_status, _cancel_errors.get(result_status, ''),
)
# I do not know what are the error generated for Finkok
# that's why I catch all, in the other hand I do not expect
# to be here never
Show 20 lines Show all unchanged lines
setup.cfg
+ 2
- 11
Show all unchanged lines Show 20 lines
order_by_type=True
# Known external packages of odoo
known_third_party=PIL, anybox.testing.openerp, argparse,babel,
dateutil, decorator, docutils, faces, feedparser,
gdata, gevent, greenlet, jcconv, jinja2,
ldap, lxml, mako, markupsafe, mock, odf,
ofxparse, openid, passlib, pkg_resources,
psutil, psycogreen, psycopg2, pyPdf, pychart,
pydot, pyparsing, pytz, qrcode, reportlab,
requests, serial, simplejson, six, suds,
unittest2, usb, vatnumber, vobject, werkzeug,
wsgiref, xlsxwriter, xlwt, yaml,
known_standard_library=PIL, anybox.testing.openerp, argparse, babel, dateutil, decorator, docutils, faces, feedparser, gdata, gevent, greenlet, jcconv, jinja2, ldap, lxml, mako, markupsafe, mock, odf, ofxparse, openid, passlib, pkg_resources, psutil, psycogreen, psycopg2, pyPdf, pychart, pydot, pyparsing, pytz, qrcode, reportlab, requests, serial, simplejson, six, suds, unittest2, usb, vatnumber, vobject, werkzeug, wsgiref, xlsxwriter, xlwt, yaml,
# Add Odoo section to force separate imports
known_odoo=odoo,openerp
Show 20 lines Show all unchanged lines Show 20 lines
# A comment to consistently place directly above imports sections.
import_heading_future=Future
#import_heading_odoo=Odoo imports
\ No newline at end of file
#import_heading_odoo=Odoo imports