Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
L
l10n_mx_facturae
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • l10n_mx
  • l10n_mx_facturae
  • Merge Requests
  • !165

Closed
Opened 2 years ago by Antonio Manzano Romero@antonio.manzanoContributor
  • Report abuse
Report abuse

fix(account.invoice): se corrige funcionalidad para cancelar facturas

  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1
2 unresolved threads
  • Loading...

Se agregó una condición donde si el estado del CFDI de la factura tiene el estado "Waiting", la factura también tendrá este estado, en caso contrario se procede a cancelarlo

Request to merge cancel_invoice into master
  • Download as
  • Email patches

  • Plain diff

Pipeline #17755 passed for 0f67b36e on cancel_invoice
Checking approval status

Closed by Antonio Manzano Romero 2 years ago (Sep 26, 2022 3:05pm GMT+0000) 2 years ago

The changes were not merged into master

Deletes source branch


  • Antonio Manzano Romero @antonio.manzano added Bug label 2 years ago

    added Bug label

  • Agustín Cruz
    Agustín Cruz @agb80 started a thread on the diff 2 years ago
    l10n_mx_facturae/models/account_invoice.py
    331 331 if cancelacion:
    332 332 super(AccountInvoice, invoice).action_cancel()
    333 333 elif cancelacion is None:
    334 invoice.write({"state": "cancel"})
    334 if invoice.cfdi_id.state == "waiting":
    335 invoice.write({"state": invoice.cfdi_id.state})
    • Agustín Cruz
      Agustín Cruz @agb80 · 2 years ago
      Owner

      Creo que de esta forma queda más fácil de entender, recuerda que el código va a ser leído más veces de las que es escrito:

      Suggested change
      335 invoice.write({"state": invoice.cfdi_id.state})
      335 invoice.write({"state": "waiting"})
    • Please register or sign in to reply
    • Agustín Cruz
      Agustín Cruz @agb80 · 2 years ago
      Owner

      @antonio.manzano dado que estás haciendo una corrección, tu rama debe de salir del último tag liberado para que se mezcle ahí mismo y podamos liberar el módulo a producción lo antes posible.

    • Please register or sign in to reply
  • Antonio Manzano Romero @antonio.manzano closed 2 years ago

    closed

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
Assign to
0 Reviewers
Request review from
None
Milestone
None
Assign milestone
None
Time tracking
No estimate or time spent
1
Labels
Bug
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
participants
Reference: l10n_mx/l10n_mx_facturae!165
Source branch: cancel_invoice

    0 pending comments