Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
L
l10n_mx_facturae
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • l10n_mx
  • l10n_mx_facturae
  • Merge Requests
  • !17

Merged
Opened 7 years ago by José Atonaltzin Maldonado Ortiz@jose.maldonadoContributor

fix (account.invoice): Improvements to the interface of the CFDI 3.3

  • Overview 10
  • Commits 1
  • Changes 3
1 unresolved thread
  • Loading...

New eyelash were created to group the fields of the CFDI 3.3, so that there would be better access, avoiding confusion between the users to locate them and make their use easier, the code_alpha3 was added to the template of guenshi to avoid the error of the invoice

Edited 7 years ago by José Atonaltzin Maldonado Ortiz
Request to merge jose.maldonado:MejorarCFDI into master
  • Download as
  • Email patches

  • Plain diff

Checking pipeline status.

Approval is optional

Merged by Agustín Cruz 7 years ago (Nov 11, 2017 11:13pm GMT+0000) 7 years ago

The changes were merged into master with 395e6dad

Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.


  • José Atonaltzin Maldonado Ortiz @jose.maldonado changed the description 7 years ago

    changed the description

  • José Atonaltzin Maldonado Ortiz @jose.maldonado assigned to @jose.maldonado 7 years ago

    assigned to @jose.maldonado

  • José Atonaltzin Maldonado Ortiz
    José Atonaltzin Maldonado Ortiz @jose.maldonado · 7 years ago
    Contributor

    Buenos dias ing. @agb80 disculpe por no pinearlo jejeje tengo dudas sobre esta mejora en la plantilla de guenshi

  • Agustín Cruz
    Agustín Cruz @agb80 · 7 years ago
    Owner

    Nada más un único comentario, el mensaje del commit. La idea es que en el paréntesis después de la palabra fix se ponga el objeto que se está modificando para identificar claramente cual es la modificación. También es importante que le pongas después una descripción lo más detallada posible del cambio que estás haciendo y los beneficios que se obtienen con el cambio (imagina que lo estás vendiendo a un cliente, que le dirías para justificar que tus cambios le son útiles y que te page)

    fix(account.invoice): improve interface

  • José Atonaltzin Maldonado Ortiz
    José Atonaltzin Maldonado Ortiz @jose.maldonado · 7 years ago
    Contributor

    Buenos dias compañeros espero su revicion para este codigo, fue una mejora a la interfaz en el modulo de facturae para que los campos del CFDI3.3 no se vieran tan amontonados en un solo lugar @cuauhtemoc.diaz @chavamm.83 @alfonso.moreno

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 1 commit 7 years ago

    added 1 commit

    • 2a383077 - fix(account.invoice): Improvements to the interface to the CFDI 3.3

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz @jose.maldonado changed title from fix(l10n_mx_facturae): Improvements to the interface to fix (account.invoice): Improvements to the interface of the CFDI 3.3 7 years ago

    changed title from fix(l10n_mx_facturae): Improvements to the interface to fix (account.invoice): Improvements to the interface of the CFDI 3.3

  • José Atonaltzin Maldonado Ortiz @jose.maldonado changed the description 7 years ago

    changed the description

  • Agustín Cruz
    Agustín Cruz @agb80 started a thread on an old version of the diff 7 years ago
    Last updated by José Atonaltzin Maldonado Ortiz 7 years ago
    l10n_mx_facturae/views/account_invoice.xml
    17 16 placeholder="Fiscal Number" readonly="1"/>
    18 17 </h4>
    19 18 </xpath>
    20 <field name="fiscal_position" position="after">
    21 <field name="cfdi_use"
    22 attrs="{'readonly': [('state', 'in', ('paid', 'open', 'cancel'))]}"
    23 options="{'no_create':True}"/>
    24 </field>
    25 19 <xpath expr="//field[@name='partner_id']" position="attributes">
    26 20 <attribute name="context">{'search_default_customer':1, 'show_address': 1, 'default_is_company': 1}</attribute>
    27 21 <attribute name="domain">[('customer', '=', True), ('is_company', '=', True)]</attribute>
    28 22 <attribute name="options">{'always_reload': True,'no_quick_create': True}</attribute>
    29 23 </xpath>
    24 <field name="fiscal_position" position="after">
    • Agustín Cruz
      Agustín Cruz @agb80 · 7 years ago
      Owner

      ¿Alguna razón en especial para mover este elemento de lugar?

    • José Atonaltzin Maldonado Ortiz
      José Atonaltzin Maldonado Ortiz @jose.maldonado · 7 years ago
      Contributor

      En estos momento me estoy haciendo la misma pregunta porque en mi sistema si esta :( jejeje

    • Agustín Cruz
      Agustín Cruz @agb80 · 7 years ago
      Owner

      Entonces podrías revertirlo por favor?

    • José Atonaltzin Maldonado Ortiz
      José Atonaltzin Maldonado Ortiz @jose.maldonado · 7 years ago
      Contributor

      yes

    • Please register or sign in to reply
  • Agustín Cruz
    Agustín Cruz @agb80 started a thread on an old version of the diff 7 years ago
    Resolved by José Atonaltzin Maldonado Ortiz 7 years ago
  • Agustín Cruz
    Agustín Cruz @agb80 started a thread on an old version of the diff 7 years ago
    Resolved by José Atonaltzin Maldonado Ortiz 7 years ago
  • Agustín Cruz
    Agustín Cruz @agb80 started a thread on an old version of the diff 7 years ago
    Resolved by José Atonaltzin Maldonado Ortiz 7 years ago
  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 1 commit 7 years ago

    added 1 commit

    • 52b03d24 - fix(account.invoice): Improvements to the interface to the CFDI 3.3

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz @jose.maldonado resolved all discussions 7 years ago

    resolved all discussions

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 1 commit 7 years ago

    added 1 commit

    • 94b59fd4 - fix(account.invoice): Improvements to the interface to the CFDI 3.3

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 1 commit 7 years ago

    added 1 commit

    • 7ba5acfc - fix(account.invoice): Improvements to the interface to the CFDI 3.3

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 1 commit 7 years ago

    added 1 commit

    • a2665452 - fix(account.invoice): Improvements to the interface to the CFDI 3.3

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 9 commits 7 years ago

    added 9 commits

    • a2665452...7f029268 - 8 commits from branch l10n_mx:master
    • 395e6dad - fix(account.invoice): Improvements to the interface to the CFDI 3.3

    Compare with previous version

  • Agustín Cruz @agb80 resolved all discussions 7 years ago

    resolved all discussions

  • Agustín Cruz @agb80 merged 7 years ago

    merged

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
Assignee
José Atonaltzin Maldonado Ortiz's avatar
José Atonaltzin Maldonado Ortiz
@jose.maldonado
Assign to
0 Reviewers
None
Request review from
None
Milestone
None
Assign milestone
None
Time tracking
No estimate or time spent
0
Labels
None
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
5
5 participants
user avatar
user avatar
user avatar
user avatar
user avatar
Reference: l10n_mx/l10n_mx_facturae!17
Source branch: MejorarCFDI

    0 pending comments