Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
L
l10n_mx_facturae
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • l10n_mx
  • l10n_mx_facturae
  • Merge Requests
  • !185

Merged
Opened 1 year ago by Elías Méndez Vázquez@elias.mendezContributor

fix(l10n_mx_facturae): se corrige cancelación de factura con cfdi en estado borrador

  • Overview 6
  • Commits 1
  • Pipelines 5
  • Changes 1
2 unresolved threads
  • Loading...

Se corrige cancelación de factura con cfdi en estado borrador

Request to merge fix_cancel_invoice into master
  • Download as
  • Email patches

  • Plain diff

Pipeline #20162 passed for 9795b34c on fix_cancel_invoice
Approval is optional

Merged by Agustín Cruz 1 year ago (May 16, 2023 12:43am GMT+0000) 1 year ago

The changes were merged into master with 478e7e81

The source branch has been deleted

Pipeline #20163 passed for 478e7e81 on master

  • Elías Méndez Vázquez @elias.mendez added 1 commit 1 year ago

    added 1 commit

    • 0850d2c7 - fix(l10n_mx_facturae): se corrige cancelación de factura con cfdi en estado borrador

    Compare with previous version

  • Elías Méndez Vázquez
    Elías Méndez Vázquez @elias.mendez started a thread on an old version of the diff 1 year ago
    l10n_mx_facturae/models/account_invoice.py
    336 336 if cancelacion:
    337 337 # CFDI cancelled (cancelacion == True) must cancel invoice too
    338 338 super(AccountInvoice, invoice).action_cancel()
    • Elías Méndez Vázquez
      Elías Méndez Vázquez @elias.mendez · 1 year ago
      Contributor

      Otra opción pudiera ser de la siguiente manera

      Suggested change
      338 super(AccountInvoice, invoice).action_cancel()
      338 super(AccountInvoice, invoice).action_cancel()
      339 elif cancelacion is None:
      340 # CFDI set to approval (cancelacion == None) must set invoice
      341 # to waiting too
      342 invoice.write({"state": "cancel"})
      343 ```
      Edited by Elías Méndez Vázquez 1 year ago
    • Please register or sign in to reply
  • Agustín Cruz
    Agustín Cruz @agb80 started a thread on an old version of the diff 1 year ago
    Last updated by Agustín Cruz 1 year ago
    l10n_mx_facturae/models/account_invoice.py
    336 336 if cancelacion:
    337 337 # CFDI cancelled (cancelacion == True) must cancel invoice too
    338 338 super(AccountInvoice, invoice).action_cancel()
    339 elif cancelacion is None:
    • Agustín Cruz
      Agustín Cruz @agb80 · 1 year ago
      Owner

      No entiendo porque borraste estas líneas @elias.mendez ???

    • Elías Méndez Vázquez
      Elías Méndez Vázquez @elias.mendez · 1 year ago
      Contributor

      @agb80 Una de las pruebas que estaba realizando funcionaba todo de manera correcta borrando esas líneas, pero después volví a probarlo pero ya no funcionaba

    • Agustín Cruz
      Agustín Cruz @agb80 · 1 year ago
      Owner

      @elias.mendez recuerda que una buena regla de todo desarrollador es que los cambios deben ser lo más puntuales posibles, es decir, no alterar nada que no esté estrictamente dentro de lo necesario para lograr el comportamiento esperado.

      Regresa estas líneas y vuelve a hacer la prueba, creo que ya con eso debe de poder funcionar sin ningún problema.

    • Please register or sign in to reply
  • Agustín Cruz @agb80 closed 1 year ago

    closed

  • Agustín Cruz @agb80 reopened 1 year ago

    reopened

  • Agustín Cruz
    Agustín Cruz @agb80 · 1 year ago
    Owner

    Perdón, cerrado por error, lo reabro :disappointed:

  • Elías Méndez Vázquez @elias.mendez restored source branch fix_cancel_invoice 1 year ago

    restored source branch fix_cancel_invoice

  • Elías Méndez Vázquez @elias.mendez added 1 commit 1 year ago

    added 1 commit

    • 19a17861 - fix(l10n_mx_facturae): se corrige cancelación de factura con cfdi en estado borrador

    Compare with previous version

  • Agustín Cruz
    Agustín Cruz @agb80 · 1 year ago
    Owner

    Un último comentario @elias.mendez, cuando pongas los mensajes del commit lo que va entre paréntesis debe ser el nombre del objeto que estás modificando no el nombre del módulo, en este caso el mensaje del commit debería quedar así:

    fix(account.invoice): se corrige cancelación de factura con cfdi en estado borrador
  • Agustín Cruz @agb80 added 3 commits 1 year ago

    added 3 commits

    • 19a17861...af61ce99 - 2 commits from branch master
    • 9795b34c - fix(account.invoice): se corrige cancelación de factura con cfdi en estado borrador

    Compare with previous version

  • Agustín Cruz @agb80 merged 1 year ago

    merged

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
Assignee
Elías Méndez Vázquez's avatar
Elías Méndez Vázquez
@elias.mendez
Assign to
Reviewer
Noe Fernando Izquierdo Hernandez's avatar
@noe.izquierdo
Request review from
None
Milestone
None
Assign milestone
None
Time tracking
No estimate or time spent
0
Labels
None
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
3
3 participants
user avatar
user avatar
user avatar
Reference: l10n_mx/l10n_mx_facturae!185
Source branch: fix_cancel_invoice

    0 pending comments