Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
L
l10n_mx_facturae
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • l10n_mx
  • l10n_mx_facturae
  • Merge Requests
  • !26

Merged
Opened 7 years ago by José Atonaltzin Maldonado Ortiz@jose.maldonadoContributor

fix(account.invoice): Error in calculation is corrected when a client is not subject to IEPS and change was reversed to iterate over the list of taxes

  • Overview 9
  • Commits 1
  • Changes 2
  • Loading...

an error occurs when validating an invoice when the client is not subject to IEPS since it returnsas a tax not registered in the list of transferred taxes, however the correct thing is to include tan error occurs when validating an invoice when the client is not subject to IEPS since it returns as a tax not registered in the list of transferred taxes, however the correct thing is to include the IEPS in the cost of the product so as not to include on the invoice. reversed the change to iterate over the list of taxes and a description is added for the account invoice tree view

Edited 7 years ago by José Atonaltzin Maldonado Ortiz
Request to merge jose.maldonado:mejora_04/01/18 into master
  • Download as
  • Email patches

  • Plain diff

Checking pipeline status.

Checking approval status

Merged by Agustín Cruz 7 years ago (Feb 22, 2018 4:19pm GMT+0000) 7 years ago

The changes were merged into master with 5f07348d

The source branch has been deleted


  • José Atonaltzin Maldonado Ortiz
    José Atonaltzin Maldonado Ortiz @jose.maldonado · 7 years ago
    Contributor

    Buenas noches compañeros espero su revicion para estos cambios aplicados al ing Salvador con respecto a una llamada que se sostubo con el dia 04/01/2018 saludos @agb80 , @cuauhtemoc.diaz

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 1 commit 7 years ago

    added 1 commit

    • 0d0af2b1 - fix(account.invoice): change was reversed to iterate over the list of taxes

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz
    José Atonaltzin Maldonado Ortiz @jose.maldonado · 7 years ago
    Contributor

    cambio realizado ing @agb80 taxes.append(tax)

  • Agustín Cruz
    Agustín Cruz @agb80 · 7 years ago
    Owner

    @jose.maldonado en esta gráfica http://gitlab.openpyme.mx/l10n_mx/l10n_mx_facturae/network/master puedes ver que en la rama master hay un commit de una feature que no estoy seguro si ya podemos incluir en una versión estable sin que eso afecte el funcionamiento en producción de los clientes, por lo tanto te pido que hagas un rebase de tu rama pero con el tag 2.4.4 que es el último tag de correcciones que se han incluido en este repositorio.

    De esta forma estas correcciones podrán llegar con los clientes a la brevedad posible sin que el feature que tenemos afecte la estabilidad de sus instalaciones.

    Gracias!!

  • José Atonaltzin Maldonado Ortiz
    José Atonaltzin Maldonado Ortiz @jose.maldonado · 7 years ago
    Contributor

    Disculpa si la cactaeristica que me emcionas es la de la adendacode ya lo revise en la nueva vesion y no causa problema alguno, procedere a realizar el rebase para qu sean incluidos estos cambios en master saludos :) :red_circle:

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 5 commits 7 years ago

    added 5 commits

    • 0d0af2b1...8f8b70fa - 5 commits from branch l10n_mx:master

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 1 commit 7 years ago

    added 1 commit

    • 8dec7c8b - fix(account.invoice): change was reversed to iterate over the list of taxes

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 4 commits 7 years ago

    added 4 commits

    • 8dec7c8b...8f8b70fa - 3 commits from branch l10n_mx:master
    • 71496a1e - fix(account.invoice): change was reversed to iterate over the list of taxes

    Compare with previous version

  • Agustín Cruz @agb80 mentioned in merge request !29 (closed) 7 years ago

    mentioned in merge request !29 (closed)

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 1 commit 7 years ago

    added 1 commit

    • fbb2c238 - fix(account.invoice): change was reversed to iterate over the list of taxes

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 9 commits 7 years ago

    added 9 commits

    • fbb2c238...af5e25b2 - 8 commits from branch l10n_mx:master
    • 0661e9a3 - fix(account.invoice): change was reversed to iterate over the list of taxes

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz
    José Atonaltzin Maldonado Ortiz @jose.maldonado · 7 years ago
    Contributor

    Hola ing. este ya esta listo para mezclarse @agb80

  • Agustín Cruz
    Agustín Cruz @agb80 · 7 years ago
    Owner

    Entonces cual de los dos MR aplicamos, este o el !26 (merged)????

  • José Atonaltzin Maldonado Ortiz
    José Atonaltzin Maldonado Ortiz @jose.maldonado · 7 years ago
    Contributor

    se va este ing @agb80

  • José Atonaltzin Maldonado Ortiz
    José Atonaltzin Maldonado Ortiz @jose.maldonado · 7 years ago
    Contributor

    @alfonso.moreno @cuauhtemoc.diaz en este lugar se aplicaron los cambios para el problema que se tenia cuando se aplicaba el IEPS con una secuencia mayor al IVA asi mismo se hace la verificacion para comprobar los impuestos aplicados

  • Agustín Cruz
    Agustín Cruz @agb80 · 7 years ago
    Owner

    Sale, nada más le puedes editar el commit para ponerle el issue que estamos cerrando con este MR, por favor!!!

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 1 commit 7 years ago

    added 1 commit

    • e3e4e221 - fix(account.invoice): change was reversed to iterate over the list of taxes

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 1 commit 7 years ago

    added 1 commit

    • 27432da2 - fix(account.invoice):se corrige error en calculo cuando un cliente no esta…

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz @jose.maldonado changed title from fix(account.invoice): change was reversed to iterate over the list of taxes to fix(account.invoice): Error in calculation is corrected when a client is not subject to IEPS and change was reversed to iterate over the list of taxes 7 years ago

    changed title from fix(account.invoice): change was reversed to iterate over the list of taxes to fix(account.invoice): Error in calculation is corrected when a client is not subject to IEPS and change was reversed to iterate over the list of taxes

  • José Atonaltzin Maldonado Ortiz @jose.maldonado changed the description 7 years ago

    changed the description

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 1 commit 7 years ago

    added 1 commit

    • 0b760280 - fix(account.invoice):Error in calculation is corrected when a client is not…

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 2 commits 7 years ago

    added 2 commits

    • e0473038 - feature (account.invoice): change the field adenda_code to l10n_mx_facturae
    • 7d3497e5 - fix(account.invoice):Error in calculation is corrected when a client is not…

    Compare with previous version

  • José Atonaltzin Maldonado Ortiz @jose.maldonado added 1 commit 7 years ago

    added 1 commit

    • 5f07348d - fix(account.invoice):Error in calculation is corrected when a client is not…

    Compare with previous version

  • Agustín Cruz @agb80 merged 7 years ago

    merged

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
Assign to
0 Reviewers
Request review from
None
Milestone
None
Assign milestone
None
Time tracking
No estimate or time spent
0
Labels
None
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
participants
Reference: l10n_mx/l10n_mx_facturae!26
Source branch: mejora_04/01/18

    0 pending comments