Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
L
l10n_mx_facturae
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • l10n_mx
  • l10n_mx_facturae
  • Merge Requests
  • !87

Merged
Opened 6 years ago by Ricardo Valencia Vélez@ricardo.valenciaContributor

fix(account_invoice): El campo seleccionar adenda es editable solo cuando la factura es borrador

  • Overview 2
  • Commits 1
  • Changes 1
  • Loading...

Cuando la factura ya se encuentra validada no es posible modificar el campo adenda, solo se podrá modificar cuando esta en estado borrador, antes se podia modificar cuando ya estaba validada lo que no es correcto:

closed #16 (closed)

Request to merge ricardo.valencia:adenda_ric into master
  • Download as
  • Email patches

  • Plain diff

Checking pipeline status.

Checking approval status

Merged by Agustín Cruz 6 years ago (Mar 28, 2019 4:10pm GMT+0000) 6 years ago

The changes were merged into master with 621eca55

Closed #16 (closed)

Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.


  • Ricardo Valencia Vélez @ricardo.valencia assigned to @ricardo.valencia 6 years ago

    assigned to @ricardo.valencia

  • Ricardo Valencia Vélez @ricardo.valencia added 1 commit 6 years ago

    added 1 commit

    • 903d93c9 - fix(account_invoice): El campo seleccionar adenda es editable solo cuando la factura es borrador.

    Compare with previous version

  • Agustín Cruz
    Agustín Cruz @agb80 · 6 years ago
    Owner

    @ricardo.valencia para ya mezclar este cambio te encargo nada más que corrijas los siguientes mensajes de los test:

    l10n_mx_facturae/models/account_invoice.py:186: [C0326(bad-whitespace), ] Exactly one space required after comma
            states={"draft":[("readonly",False)]},
    ./l10n_mx_facturae/models/account_invoice.py:186:24: E231 missing whitespace after ':'
    ./l10n_mx_facturae/models/account_invoice.py:186:37: E231 missing whitespace after ','

    Gracias de antemano!!!

  • Agustín Cruz @agb80 added Bug label 6 years ago

    added Bug label

  • Agustín Cruz
    Agustín Cruz @agb80 · 6 years ago
    Owner

    ping @OpenPymeMx

  • Ricardo Valencia Vélez @ricardo.valencia added 1 commit 6 years ago

    added 1 commit

    • 98f9fc5f - fix(account_invoice): El campo seleccionar adenda es editable solo cuando la factura es borrador.

    Compare with previous version

  • Agustín Cruz @agb80 added 3 commits 6 years ago

    added 3 commits

    • 98f9fc5f...f7ded6a7 - 2 commits from branch l10n_mx:master
    • d9c37dd8 - fix(account_invoice): El campo seleccionar adenda es editable solo cuando la factura es borrador.

    Compare with previous version

  • Agustín Cruz @agb80 merged 6 years ago

    merged

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
Assign to
0 Reviewers
Request review from
None
Milestone
None
Assign milestone
None
Time tracking
No estimate or time spent
1
Labels
Bug
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
participants
Reference: l10n_mx/l10n_mx_facturae!87
Source branch: adenda_ric

    0 pending comments